[branch-50] Extend datatype semantic equality check to include timestamps (#17777) #18129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#17777) * Extend datatype semantic equality to include timestamps * test * Respond to comments * cargo fmt --------- Co-authored-by: Shiv Bhatia <[email protected]>
This was referenced Oct 17, 2025
shivbhatia10
approved these changes
Oct 17, 2025
alamb
changed the title
|
Merging to pick up #18141 and try and get a clean CI run |
alamb
reviewed
Oct 19, 2025
datafusion/common/src/dfschema.rs
Outdated
| )); | ||
|
|
||
| // Succeeds if decimal precision and scale are different | ||
| assert!(DFSchema::datatype_is_semantically_equal( |
There was a problem hiding this comment.
these decimal tests appear to have been backported from main without the corresponding code. I will remove them
alamb
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
50.3.0(minor) #18072Rationale for this change
If I've understood semantic equality correctly, any two timestamps should meet the bar for equality regardless of time units and timezones, but the current code doesn't reflect that.
What changes are included in this PR?
Adds a branch to this method for timestamps.
Are these changes tested?
Yes
Are there any user-facing changes?
Yes